Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK/CLI] Write instance_results.jsonl path in run properties #3014

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[SDK/CLI] Write instance_results.jsonl path in run properties #3014

merged 1 commit into from
Apr 25, 2024
+12 −23

Conversation

0mza987
Copy link
Contributor

@0mza987 0mza987 commented Apr 25, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@0mza987 0mza987 requested a review from a team as a code owner April 25, 2024 09:49
@github-actions GitHub Actions
Copy link

promptflow SDK CLI Azure E2E Test Result hod/fix

  4 files    4 suites   4m 59s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit c98e5e1.

@github-actions GitHub Actions
Copy link

SDK CLI Global Config Test Result hod/fix

5 tests   5 ✅  1m 14s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c98e5e1.

@github-actions GitHub Actions
Copy link

Executor Unit Test Result hod/fix

792 tests   792 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c98e5e1.

@github-actions GitHub Actions
Copy link

Executor E2E Test Result hod/fix

241 tests   235 ✅  5m 11s ⏱️
  1 suites    5 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit c98e5e1.

@github-actions GitHub Actions
Copy link

SDK CLI Test Result hod/fix

    4 files      4 suites   57m 22s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit c98e5e1.

@0mza987 0mza987 merged commit 6399905 into main Apr 25, 2024
40 of 42 checks passed
@0mza987 0mza987 deleted the hod/fix branch April 25, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

Assignees
No one assigned
Labels
promptflow-azure promptflow-devkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mza987 @zhengfeiwang @wangchao1230